fix : Added Examples of Named List Elements in i to Improve Clarity #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6868 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 79 79
Lines 14661 14661
=======================================
Hits 14455 14455
Misses 206 206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -191,33 +191,64 @@ flights[.("JFK", "LAX"), on = c("origin", "dest")][1:5] | |||
|
|
|||
| * Since the time to compute the secondary index is quite small, we don't have to use `setindex()`, unless, once again, the task involves repeated subsetting on the same column. | |||
|
|
|||
| ### b) Select in `j` | |||
There was a problem hiding this comment.
I think we can shrink the diff in this PR to basically one line. Instead of a new 'c)' entry here, I would add a bullet point here like
* For clarity/readability, it might help to name the inputs to `i`, e.g. `flights[.(origin = "JFK", dest = "LAX"), on=c("origin", "dest")]`
I'm not convinced any of the other changes add enough value to warrant inclusion.
There was a problem hiding this comment.
@MichaelChirico , I've updated the section based on your suggestion. Do you think it needs more detail, or does it look good as is? Whenever you have time, I'd appreciate your review. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1945
This PR updates data.table joins to use named lists (on = .(...)) instead of unnamed character vectors (on = c("col1", "col2")).
in this I modified
*** vignettes/datatable-secondary-indices-and-auto-indexing.Rmd:
@jangorecki @MichaelChirico can you please review this when you have time.
thanks.