Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention 14-year-old version info in ?alloc.col #6887

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Mar 26, 2025

v1.7.2 is from 2011, I don't think it's relevant to detail a before/after 2011 distinction any more.

R 2.14.0 is also from 2011.

https://cran.r-project.org/src/contrib/Archive/data.table/
https://github.com/wch/r-source/tree/tags/R-2-14-0

Also wrapped some of the text, not all IDEs do text wrapping so these very-very wide lines are a bit hard to work with.

@MichaelChirico MichaelChirico requested a review from tdhock March 26, 2025 16:05
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (77b4394) to head (8e3b4a4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6887   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          79       79           
  Lines       14665    14665           
=======================================
  Hits        14459    14459           
  Misses        206      206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
Copy link
Member

LGTM. It's gonna be 19 years of DT on April 15th!

@ben-schwen ben-schwen merged commit 2cb0316 into master Mar 27, 2025
10 checks passed
@ben-schwen ben-schwen deleted the doc-alloc-col-ancient branch March 27, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants