-
Notifications
You must be signed in to change notification settings - Fork 2
[CA-4639] True React SDK #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bf8efc5
to
f96db63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comment and some conflict and that's good
@@ -238,6 +236,7 @@ export function createForm<Model extends Record<PropertyKey, unknown> = {}, P = | |||
}; | |||
|
|||
const handleError = (err: unknown) => { | |||
console.error(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps better to remove console no ?
@@ -49,83 +53,81 @@ export interface WidgetProps { | |||
// type PropsWithWidgetProps<P> = P & WidgetProps | |||
type WidgetOptions<P> = Prettify<P & WidgetProps & I18nProps & ThemeProps> | |||
|
|||
type Widget<P> = (props: P, ctx: Context) => Promise<React.JSX.Element> | |||
// type Widget<P> = (props: P, ctx: Context) => Promise<React.JSX.Element> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing type ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parce qu'il est devenu inutile. Mais par contre j'ai oublié de le retirer complètement.
CA-4639
The aime of this RP is to be able to use widgets as React component to be use as follow :
Furthermore, ReachfiveProvider leverage the use of Suspense API and expose a
fallback
property to provide content to render during configuration loading and widget initialization.