Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the normal mode displacement TS check #768

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Fix the normal mode displacement TS check #768

wants to merge 27 commits into from

Conversation

alongd
Copy link
Member

@alongd alongd commented Oct 7, 2024

The normal model displacement check was fixed, a new module for this check was added.
Tests added, though more thorough testing for the overall functionality are still needed.

arc/checks/nmd.py Fixed Show fixed Hide fixed
arc/checks/nmd.py Fixed Show fixed Hide fixed
arc/checks/nmd_test.py Fixed Show fixed Hide fixed
arc/species/converter.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 94.43609% with 37 lines in your changes missing coverage. Please review.

Project coverage is 74.41%. Comparing base (fb16f4a) to head (06254f9).

Files with missing lines Patch % Lines
arc/checks/nmd.py 89.11% 13 Missing and 8 partials ⚠️
arc/species/converter.py 82.75% 5 Missing ⚠️
arc/checks/ts.py 62.50% 1 Missing and 2 partials ⚠️
arc/species/species.py 75.00% 3 Missing ⚠️
arc/checks/nmd_test.py 99.25% 1 Missing and 1 partial ⚠️
arc/reaction.py 96.66% 0 Missing and 2 partials ⚠️
arc/scheduler.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   74.09%   74.41%   +0.31%     
==========================================
  Files         101      103       +2     
  Lines       28005    28465     +460     
  Branches     5860     5935      +75     
==========================================
+ Hits        20751    21182     +431     
- Misses       5786     5810      +24     
- Partials     1468     1473       +5     
Flag Coverage Δ
?
unittests 74.41% <94.43%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant