Skip to content

Swift package manager support + compile from command line #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Swift package manager support + compile from command line #5

wants to merge 2 commits into from

Conversation

@mrtj
Copy link

@mrtj mrtj commented Feb 7, 2017

Fixes #4

srdanrasic
srdanrasic reviewed Feb 7, 2017
View reviewed changes
Sources/Request.swift
// THE SOFTWARE.
//

import Cocoa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I don't think it will compile in iOS targets.

@mrtj
Copy link
Author

mrtj commented Feb 8, 2017

import Cocoa is needed only if you compile the project for macOS platform; without it the compiler laments with "use of undeclared type 'NSError'" type errors. Sorry for not checking the build break on iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srdanrasic srdanrasic srdanrasic left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrtj @srdanrasic