fix: Add SEO Page Title for 2 pages - #7326
Conversation
6d5e570 to
ceaddb8
Compare
jakovljevic-mladen
left a comment
There was a problem hiding this comment.
Please revert one of the changes (the second example from the PR description) as it is redundant. And also please merge master branch to resolve conflicts. Otherwise, looks good.
| @@ -1 +1,2 @@ | |||
| <h1 class="no-toc">Team</h1> | |||
| "picture": "https://avatars0.githubusercontent.com/u/49051", | ||
| "twitter": "https://twitter.com/mattpodwysocki", | ||
| "group": "Alumn" | ||
| "group": "Alumni" |
There was a problem hiding this comment.
As a non-native English speaker, I hope this one is right 🙂 I don't really know. Maybe @benlesh can help?
|
Hi @ajitzero — thank you for the time, care, and thoughtfulness you put into this pull request. I’m sorry we weren’t able to respond in a reasonable timeframe. Since the codebase and surrounding context have moved on and this hasn’t seen recent activity, I’m going to close it for now. That’s a reflection of our delayed triage, not a lack of appreciation for your contribution. If the change is still relevant, please feel welcome to open a fresh pull request against the current codebase. Thank you again for contributing to RxJS and for your patience. — Ben |

Description:
h1tag of a page in this component.h1tag was placed within the component for the page and not in the HTML file itself. Moved it into the correct file now.h1tag. Added this now.Related issue (if exists):
None
Screenshot of fix:
#linkI suggest squash-committing this since I edited the commit messages via GitHub UI and will not pass commit-lint.Fixed commit messages.