Skip to content

fix: Add SEO Page Title for 2 pages - #7326

Closed
ajitzero wants to merge 3 commits into
ReactiveX:masterfrom
ajitzero:fix/odt-page-title
Closed

fix: Add SEO Page Title for 2 pages#7326
ajitzero wants to merge 3 commits into
ReactiveX:masterfrom
ajitzero:fix/odt-page-title

Conversation

@ajitzero

@ajitzero ajitzero commented Aug 19, 2023

Copy link
Copy Markdown

Description:

  • The page title is taken from the h1 tag of a page in this component.
    • For "Operator Decision Tree", the h1 tag was placed within the component for the page and not in the HTML file itself. Moved it into the correct file now.
    • For "Team", there was no h1 tag. Added this now.
  • Typo: "Alumn" should be "Alumni". Unrelated to the above, but I noticed it and included it here. I can remove it from here and submit it separately if anyone has strong opinions about that.

Related issue (if exists):
None

Screenshot of fix:

Case Before After
Page title of "Operator Decision Tree" & inline # link image image
Page title of "Team" image image
Typo in "Team" > "Alumni" image image

I suggest squash-committing this since I edited the commit messages via GitHub UI and will not pass commit-lint. Fixed commit messages.

@ajitzero ajitzero changed the title fix: SEO Page Title for Operator Decision Tree fix: Add SEO Page Title for 2 pages Aug 19, 2023
@ajitzero
ajitzero marked this pull request as ready for review August 19, 2023 13:21
@ajitzero
ajitzero force-pushed the fix/odt-page-title branch from 6d5e570 to ceaddb8 Compare August 19, 2023 13:25

@jakovljevic-mladen jakovljevic-mladen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert one of the changes (the second example from the PR description) as it is redundant. And also please merge master branch to resolve conflicts. Otherwise, looks good.

@@ -1 +1,2 @@
<h1 class="no-toc">Team</h1>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this heading is not needed. The reason for this is that the heading is still visible in the top header:

image

Please revert this one.

"picture": "https://avatars0.githubusercontent.com/u/49051",
"twitter": "https://twitter.com/mattpodwysocki",
"group": "Alumn"
"group": "Alumni"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a non-native English speaker, I hope this one is right 🙂 I don't really know. Maybe @benlesh can help?

@benlesh

benlesh commented Jul 22, 2026

Copy link
Copy Markdown
Member

Hi @ajitzero — thank you for the time, care, and thoughtfulness you put into this pull request. I’m sorry we weren’t able to respond in a reasonable timeframe. Since the codebase and surrounding context have moved on and this hasn’t seen recent activity, I’m going to close it for now. That’s a reflection of our delayed triage, not a lack of appreciation for your contribution. If the change is still relevant, please feel welcome to open a fresh pull request against the current codebase. Thank you again for contributing to RxJS and for your patience.

— Ben

@benlesh benlesh closed this Jul 22, 2026
@ajitzero
ajitzero deleted the fix/odt-page-title branch July 22, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants