Skip to content

fix: Add SEO Page Title for 2 pages #7326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajitzero wants to merge 3 commits into from
Closed

fix: Add SEO Page Title for 2 pages #7326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b4ae6c
fix: Add Page title for Operator Decision Tree
ajitzero Aug 19, 2023
a9e71f9
fix: Rename "Alumn" to "Alumni"
ajitzero Aug 19, 2023
ceaddb8
fix: Add Page title for Team page
ajitzero Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs_app/content/marketing/contributors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"github": "https://github.com/mattpodwysocki",
"picture": "https://avatars0.githubusercontent.com/u/49051",
"twitter": "https://twitter.com/mattpodwysocki",
"group": "Alumn"
"group": "Alumni"

@jakovljevic-mladen jakovljevic-mladen Dec 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a non-native English speaker, I hope this one is right 🙂 I don't really know. Maybe @benlesh can help?

},
"andre": {
"name": "André Staltz",
Expand All @@ -119,7 +119,7 @@
"picture": "https://avatars0.githubusercontent.com/u/90512",
"twitter": "https://twitter.com/andrestaltz",
"website": "http://staltz.com",
"group": "Alumn"
"group": "Alumni"
},
"jay": {
"name": "Jay Phelps",
Expand All @@ -128,7 +128,7 @@
"picture": "https://avatars0.githubusercontent.com/u/762949",
"twitter": "https://twitter.com/_jayphelps",
"website": "http://jayphelps.com",
"group": "Alumn"
"group": "Alumni"
},
"nat": {
"name": "Natalie Smith",
Expand Down
3 changes: 2 additions & 1 deletion docs_app/content/marketing/operator-decision-tree.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
<aio-operator-decision-tree></aio-operator-decision-tree>
<h1 class="no-toc">Operator Decision Tree</h1>
<aio-operator-decision-tree></aio-operator-decision-tree>
1 change: 1 addition & 0 deletions docs_app/content/marketing/team.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
<h1 class="no-toc">Team</h1>

@jakovljevic-mladen jakovljevic-mladen Dec 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this heading is not needed. The reason for this is that the heading is still visible in the top header:

image

Please revert this one.

<aio-contributor-list></aio-contributor-list>
2 changes: 1 addition & 1 deletion docs_app/src/app/custom-elements/contributor/contributor.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Contributor, ContributorGroup } from './contributors.model';
import { CONTENT_URL_PREFIX } from 'app/documents/document.service';

const contributorsPath = CONTENT_URL_PREFIX + 'contributors.json';
const knownGroups = ['Core Team', 'Learning Team', 'Alumn', 'Contributors'];
const knownGroups = ['Core Team', 'Learning Team', 'Alumni', 'Contributors'];

@Injectable()
export class ContributorService {
Expand Down
1 change: 0 additions & 1 deletion docs_app/src/app/custom-elements/operator-decision-tree/operator-decision-tree.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { OperatorDecisionTreeService } from './operator-decision-tree.service';
@Component({
selector: 'aio-operator-decision-tree',
template: `
<h1 class="mat-heading" tabindex="0">Operator Decision Tree</h1>
<ng-container *ngIf="!(hasError$ | async); else hasErrorTemplate">
<h2 class="mat-subheading-2" tabindex="0">
{{ currentSentence$ | async }}
Expand Down