Skip to content

chore: bump black and mypy to most recent with py 3.8 support #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhdaines merged 1 commit into from
Dec 13, 2024
Merged

chore: bump black and mypy to most recent with py 3.8 support #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ repos:
- id: check-yaml
- id: check-added-large-files
- repo: https://github.com/psf/black
rev: 24.3.0
rev: 24.8.0
hooks:
- id: black
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.991
rev: v1.13.0
hooks:
- id: mypy
- repo: https://github.com/PyCQA/isort
Expand Down
1 change: 0 additions & 1 deletion py/soundswallower/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ def make_argparse() -> argparse.ArgumentParser:
grammars.add_argument("-t", "--align-text", help="Input text for force alignment.")
grammars.add_argument("-g", "--grammar", help="Grammar file for recognition.")
grammars.add_argument("-f", "--fsg", help="FSG file for recognition.")
parser.add_argument_group(grammars)
return parser


Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ dev = [
"pytest",
"numpy",
"pre-commit",
"black==24.3.0",
"black==24.8.0",
"isort",
"mypy==0.991",
"mypy==1.13.0",
Copy link
Contributor

@cclauss cclauss Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tools run OUTSIDE of pre-commit?

Copy link
Member Author

@joanise joanise Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, yes, though not automatically. I certainly prefer to have them installed in my venv and ready to call from the bash prompt. In all my projects, pip install -e .[dev] will give me black, isort, mypy, usually flake8 too, with whatever configuration is needed to "just work".

]

[project.urls]
Expand Down
Loading