Skip to content

Conversation

@alex-s168
Copy link
Contributor

No description provided.

@flysand7
Copy link
Contributor

wtf, getpid() isn't used in the parser. Lol?

@alex-s168
Copy link
Contributor Author

wtf, getpid() isn't used in the parser. Lol?

it's used in some file included only by the parser. I don't remember which one

@flysand7
Copy link
Contributor

flysand7 commented Oct 15, 2025

Sorry for being somewhat rude. If it was a fix, then I have two comments on this:

  1. If it's used somewhere else it's probably best to include it in that file instead.
  2. unistd.h is a POSIX-specific header, so this won't compile on windows. Perhaps it would make sense to make this inclusion platform-specific as well, or isolate the part that uses getpid() so it works on both *nix and windows.

@alex-s168
Copy link
Contributor Author

  1. I would've done that, but the original file didn't have any includes itself either
  2. I was under the impression that windows has unistd.h but it's just mostly useless, yes you're right

but also I can't find the getpid() call on master anymore (from github mobile), so it seems like NeGate removed it already

@Carlyle-Foster
Copy link

Carlyle-Foster commented Oct 15, 2025

getpid() is used in the common/log.h but so is the necessary include. the use in cuikgo is indeed gone (sic, mixed up dev and master, i checked and the file in question is cuik_go/gc.c. as to why alex can't find it anymore, maybe they made the same mistake?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants