ci(Konflux): re-enable hermetic builds - #2871
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe change enables hermetic inputs in pull-request and push Tekton PipelineRuns. The Dockerfile uses Estimated code review effort: 3 (Moderate) | ~20 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b41998f to
ae34596
Compare
|
CI probably needs |
ae34596 to
ff61702
Compare
RoamingNoMaD
left a comment
There was a problem hiding this comment.
Also, please test the resulting image. Jenkins uses a different one, so you can't trust IQE results.
| microdnf install --nodocs -y $deps $devDeps $extras && \ | ||
| chmod +t /tmp && \ | ||
| ( [[ $HERMETIC == "true" ]] || gem update --system -N --install-dir=/usr/share/gems --bindir /usr/bin ) && \ | ||
| ( [[ $HERMETIC == "true" ]] || gem install bundler ) && \ |
There was a problem hiding this comment.
Can we get rid of the back-and-forth commits please?
ff61702 to
c6465b1
Compare
|
Squashed and updated |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: afb538f3-a0fd-490b-912e-f68c11112527
⛔ Files ignored due to path filters (1)
.hermetic_builds/cargo/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.hermetic_builds/cargo/Cargo.toml.tekton/compliance-backend-pull-request.yaml.tekton/compliance-backend-push.yamlDockerfilerpms.lock.yaml
c6465b1 to
a601eab
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 0ea9c301-5262-4083-8b31-57a802882e1b
⛔ Files ignored due to path filters (1)
.hermetic_builds/cargo/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.hermetic_builds/cargo/Cargo.toml.tekton/compliance-backend-pull-request.yaml.tekton/compliance-backend-push.yamlDockerfilerpms.lock.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
- .tekton/compliance-backend-push.yaml
- .tekton/compliance-backend-pull-request.yaml
- rpms.lock.yaml
- Dockerfile
a990101 to
9d1505d
Compare
Signed-off-by: Roman Blanco <rblanco@redhat.com>
9d1505d to
f5ca2a2
Compare
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist
0.5.0, which includes Hermeto0.58.0.HERMETIChandling for dependency setup and Cargo configuration.prometheus-client-mmap1.5.0.