This repository was archived by the owner on Sep 17, 2025. It is now read-only.
fix(RHINENG-11369): CreateGroupModal returns to previous modal#887
Merged
ezr-ondrej merged 1 commit intoMar 26, 2025
Merged
Conversation
darkeriossss
requested review from
ezr-ondrej,
loadtheaccumulator and
mgold1234
as code owners
ezr-ondrej
reviewed
Mar 26, 2025
Member
ezr-ondrej
left a comment
ezr-ondrej
left a comment
There was a problem hiding this comment.
Thank you for looking into it! 🧡 Just one question, looks good apart of it ;)
| 'create-group-btn': { | ||
| component: CreateGroupButton, | ||
| closeModal: () => { | ||
| setIsCreateGroupModalOpen(true); |
Member
There was a problem hiding this comment.
Just a question, I'm just not sure here:
Why don't we call setIsModalOpen(false) here anymore?
Contributor
Author
There was a problem hiding this comment.
it causes the entire component to be removed from the DOM (src/Routes/Devices/Inventory.js, line 365) and since the child modal is exactly that (a child modal), it needs the host modal to be in the DOM
darkeriossss
force-pushed
the
create-group-modal-fix
branch
from
6d0f42d to
0c0e403
Compare
❗ Outdated dependencies error
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue, where Create Workspace Modal closed it's host modal as well on cancel
Also fixed small issue with Toolbar spacing when using table in Inventory
Fixes # RHINENG-11369
Type of change
What is it?