Fix compilation of rh.fftlib with GCC 9 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C 9. Newer versions of the STL library apparently use rebind in places they did not before. Because fftw_allocator<T> inherits from std::allocator<T>, it also inherits that rebind unless it is overridden. This caused std::vector to be unable to compile with fftw_allocator due to the mismatch of allocator types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was specifically discovered with Yocto Zeus, but can also be reproduced with the Software Collections Library on CentOS 7.
Newer versions of the GNU STL library apparently use the allocator template
rebindin places they did not before. Becausefftw_allocator<T>inherits fromstd::allocator<T>, it also inherits thatrebindunless it is overridden. This causes compilation ofstd::vector<T, fftw_allocator<T> >to fail due to the mismatch of allocator types.