Wrapped BTB algorithm for SPRAS integration #204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finished testing the LocalNeighborhood. Moving to make the dockerfile
Need to update Docker image to v2 then pull Docker image. Once the new image is in SPRAS, the final checks should work.
BTB should be ready to be implemented into SPRAS.
sumedhars
reviewed
Feb 12, 2025
Contributor
sumedhars
left a comment
sumedhars
left a comment
There was a problem hiding this comment.
- all tests passed
- btb ran successfully
| for line in edge_file: | ||
| line = line.strip() | ||
| line = line.split('\t') | ||
| line = line[2] |
Contributor
There was a problem hiding this comment.
can be colllapsed into:
_ = line.strip().split('\t')[2]
instead of:
line = line.strip() line = line.split('\t') line = line[2]
| line = line.split('\t') | ||
| line = line[2] | ||
|
|
||
| except Exception as err: |
Contributor
There was a problem hiding this comment.
maybe raise an IndexError instead? can say that edge file isnt formatted correctly/etc
agitter
reviewed
Mar 14, 2025
Collaborator
There was a problem hiding this comment.
This pull request deletes several of the LocalNeighborhood files. Can you please restore those?
Merged
Collaborator
|
[closed in favor of #250] |
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish wrapping BowTieBuilder pathway reconstruction algorithm into SPRAS environment.
BTB connects multiple source nodes to multiple target nodes in a "BowTie" shape. It can consider weighted edges and works on both directed and undirected graphs.