Skip to content

refactor(config)!: drop directed setting #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tristan-f-r wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(config)!: drop directed setting #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b935f84
chore(config): drop directed setting
tristan-f-r Oct 23, 2025
3d2a29d
chore: lint
tristan-f-r Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions spras/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ def process_algorithms(self, raw_config: RawConfig):
# Do not parse the rest of the parameters for this algorithm if it is not included
continue

if cur_params.directed is not None:
warnings.warn("UPDATE: we no longer use the directed key in the config file", stacklevel=2)

cur_params = cur_params.__pydantic_extra__
if cur_params is None:
raise RuntimeError("An internal error occurred: ConfigDict extra should be set on AlgorithmParams.")
Expand Down
3 changes: 1 addition & 2 deletions spras/config/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"""

import re
from typing import Annotated, Optional
from typing import Annotated

from pydantic import AfterValidator, BaseModel, ConfigDict, Field

Expand Down Expand Up @@ -103,7 +103,6 @@ class ContainerRegistry(BaseModel):

class AlgorithmParams(BaseModel):
include: bool
directed: Optional[bool] = None

# TODO: use array of runs instead. We currently rely on the
# extra parameters here to extract the algorithm parameter information,
Expand Down
Loading