Skip to content

cleanup a bit #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

cleanup a bit #3

wants to merge 6 commits into from

Conversation

amine4567
Copy link

@amine4567 amine4567 commented Jul 19, 2024 •
edited
Loading

  • Added type hints for better type safety
  • Added requirements.txt and requirements-dev.txt for dependency management
  • Applied black autoformatter for consistent code style
  • Added .gitignore to exclude unnecessary files
  • Updated CONTRIBUTING.md with instructions on installing dependencies for development
  • Updated README.md to use snake_case in the example

drisc
drisc approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@drisc drisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, verified locally.

Thanks for adding a requirements.txt, I didn't think to do that with the initial commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@drisc drisc drisc approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amine4567 @drisc