Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FapDungeonRipper (Issue #1979) #2056

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

metaprime
Copy link
Contributor

@metaprime metaprime commented Jan 4, 2025

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

Implemented FapDungeon ripper, as requested in #1979. As implemented, this works to get the largest resolution available of all images and videos, as tested on the 3 URLs in the unit test file.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@soloturn soloturn merged commit ba76d3d into RipMeApp:main Jan 4, 2025
1 of 4 checks passed
@metaprime metaprime deleted the fapdungeon-ripper-pr branch January 4, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants