Fixes a couple errors in alignment#18
Open
sfwasleski wants to merge 2 commits intoauto-align-attempt2from
Open
Fixes a couple errors in alignment#18sfwasleski wants to merge 2 commits intoauto-align-attempt2from
sfwasleski wants to merge 2 commits intoauto-align-attempt2from
Conversation
Fixes some target calculations in field constants Filters out really bad tag reads to avoid the occasional wild run like when I got ran over and the ones that flew off to the right.
Contributor
Author
|
BTW, the AndyMark field fix (it is two inches narrower) has be a little confused. I would expect the tag 18 y value to be 1 inch less in the official field diagrams, but it is just 0.2 inches less (same for other like oriented reef tags). We may want to use the tag 18 value as the reef y value center and not calculate it from the field width. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some target calculations in field constants
Filters out really bad tag reads to avoid the occasional wild run like when I got ran over and the ones that flew off to the right.