Skip to content

Conversation

@LightningBoltz21
Copy link

Fixes issue #5322. NOTE: the functionality of the controller has not been tested yet, but I'm making a PR so what I have so far can be reviewed.

@LightningBoltz21
Copy link
Author

I believe the linting is failing because Pint and PHPCS have conflicting documentation.

For example:
valid in Pint, not valid in PHPCS
$result = $sponsorUser->attemptLoginUsingOneTimePassword((string) $request->input('otp'));

not valid in Pint, valid in PHPCS
$result = $sponsorUser->attemptLoginUsingOneTimePassword( (string) $request->input('otp'));

return response()->json([
'success' => true,
'message' => 'Login successful! Redirecting to dashboard...',
'redirect' => route('home'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this redirect to? If it goes to the normal home page, we will need to change it to a sponsor-specific page before deploying the app.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to set up some page for this controller to redirect to. It will probably be blank/a placeholder for now.

@jvogt23 jvogt23 requested a review from kberzinch November 15, 2025 23:01
Copy link
Member

@kberzinch kberzinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, couple cleanup items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants