-
Notifications
You must be signed in to change notification settings - Fork 7
Sponsor Login Controller #5372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sponsor Login Controller #5372
Conversation
|
I believe the linting is failing because Pint and PHPCS have conflicting documentation. For example: not valid in Pint, valid in PHPCS |
| return response()->json([ | ||
| 'success' => true, | ||
| 'message' => 'Login successful! Redirecting to dashboard...', | ||
| 'redirect' => route('home'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this redirect to? If it goes to the normal home page, we will need to change it to a sponsor-specific page before deploying the app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intend to set up some page for this controller to redirect to. It will probably be blank/a placeholder for now.
Co-authored-by: Kristaps Berzinch <[email protected]>
kberzinch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, couple cleanup items
Fixes issue #5322. NOTE: the functionality of the controller has not been tested yet, but I'm making a PR so what I have so far can be reviewed.