Merged
Conversation
added 4 commits
December 20, 2024 10:29
bjsowa
requested changes
Dec 21, 2024
Member
bjsowa
left a comment
bjsowa
left a comment
There was a problem hiding this comment.
I appreciate the effort but would you mind removing the Werror option? I'm not a fan of it as it creates a dependency on specific toolchain versions.
Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
Contributor
Author
Flag removed |
bjsowa
approved these changes
Dec 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling compile warnings as errors to avoid future bugs.
My current job require these flags on so I thoght it would be nice to include these little changes here.
Hope it helps.