Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): autocomplete on known fields #6116

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(a11y): autocomplete on known fields #6116

wants to merge 2 commits into from
+11 −3

Conversation

OtavioStasiak
Copy link
Contributor

Proposed changes

Added autoComplete prop on known fields like email, name and password.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-93

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review January 28, 2025 17:17
@Rohit3523
Copy link
Contributor

Rohit3523 commented Jan 28, 2025 •
edited
Loading

I think this PR will closes #5058

diegolmello
diegolmello requested changes Feb 14, 2025
View reviewed changes
app/containers/ActionSheet/ActionSheetContentWithInputAndSubmit/index.tsx
@@ -102,6 +103,7 @@ const ActionSheetContentWithInputAndSubmit = ({
showInput?: boolean;
inputs?: { placeholder: string; secureTextEntry?: boolean; key: string }[];
isDisabled?: (inputValues: string[]) => boolean;
autoComplete?: TextInputProps['autoComplete'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get it.
You did it on ActionSheetContentWithInputAndSubmit, but I search for <ActionSheetContentWithInputAndSubmit and there's no autoComplete prop added anywhere.
Is it done on another PR?

@diegolmello diegolmello changed the title chore(a11y): autocomplete on known fields feat(a11y): autocomplete on known fields Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OtavioStasiak @Rohit3523 @diegolmello