feat: migrate to expo-image-picker #6143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
force-pushed
the
feat.image-picker
branch
from
508b04f to
f96915e
Compare
diegolmello
commented
Feb 20, 2025
diegolmello
force-pushed
the
feat.image-picker
branch
from
eedacf4 to
aed4f49
Compare
OtavioStasiak
requested changes
Feb 20, 2025
| let image = await ImagePicker.openCamera({ ...IMAGE_PICKER_CONFIG, ...libPickerLabels }); | ||
| image = forceJpgExtension(image); | ||
| const file = image as any; // FIXME: unify those types to remove the need for any | ||
| const result = await ImagePicker.launchCameraAsync(IMAGE_PICKER_CONFIG); |
There was a problem hiding this comment.
I found an issue:
- On iOS, if you uninstall and reinstall the app, then try to take a photo, it doesn’t request permission and doesn’t work as shown in the attached video. Maybe we could manually request permission? Expo Docs
Tested on RoomView and EditAvatarView;
iPhone 13 (iOS 17.6.1)
Testflight version 73787
on android everything works as expected.
WhatsApp.Video.2025-02-20.at.15.34.15.mp4
| @@ -55,16 +53,19 @@ export const useChooseMedia = ({ | |||
|
|
|||
| const takeVideo = async () => { | |||
| try { | |||
| const video = await ImagePicker.openCamera({ ...VIDEO_PICKER_CONFIG, ...libPickerLabels }); | |||
| const file = video as any; // FIXME: unify those types to remove the need for any | |||
| const result = await ImagePicker.launchCameraAsync(VIDEO_PICKER_CONFIG); | |||
There was a problem hiding this comment.
I found an issue:
- On iOS, if you uninstall and reinstall the app, then try to record a video, it doesn’t request permission and doesn’t work as shown in the attached video. Maybe we could manually request permission? Expo Docs
(Tested on roomView trying to send a video);
iPhone 13 (iOS 17.6.1)
Testflight version 73787
on android everything works as expected.
WhatsApp.Video.2025-02-20.at.15.34.10.mp4
Testflight version 73787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
NATIVE-762