Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unread count issue in subscriptions.get route #31459

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Parvezkhan0
Copy link

Proposed changes (including videos or screenshots)

Resolved the issue related to incorrect unread message counts in the subscriptions.get route. Adjusted the subscriptions.get, subscriptions.read, and subscriptions.unread routes for improved accuracy. Removed subscriptions.getOne route as it was not contributing to the correct behavior.

Issue(s)

Closes #23977

Steps to test or reproduce

  1. Go to a channel with unread messages.
  2. Check the unread message count using the /api/v1/subscriptions.get API.
  3. Confirm that the unread count now reflects the correct number of unread messages.

Further comments

Tested locally to ensure the changes fix the issue and don't introduce new problems. Removed subscriptions.getOne route as it seemed unnecessary for the use case.

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: d7180c3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Parvez Khan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Parvezkhan0
Copy link
Author

@ggazzo I have added the changesets. I hope my PR is good now.

@KevLehman
Copy link
Contributor

Thanks for contributing :)

I haven't checked your PR, but a suggestion: pls use the lint config from the project before pushing, so we can get on the PR only the changes that fix the issue, instead of unrelated prettier changes 🤗

Also, as a rule, don't remove endpoints. An endpoint removal needs to be evaluated and then changed on a Major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private message unread count 0 for normal user
5 participants