feat: Ability to set video conf ringing/dialing volume #34926
+56
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug in the volume control logic where setting a volume to 0 would incorrectly reset it to 100. This happened because the original code used the logical OR operator (||), which treats 0 as a falsy value. The fix replaces || with the nullish coalescing operator (??), which only falls back to the default value when the input is null or undefined, not when it's 0.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
rique223
changed the title
🦋 Changeset detectedLatest commit: 4600c1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34926 +/- ##
===========================================
- Coverage 59.18% 59.18% -0.01%
===========================================
Files 2821 2821
Lines 68141 68137 -4
Branches 15154 15154
===========================================
- Hits 40327 40324 -3
+ Misses 24979 24978 -1
Partials 2835 2835
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
reviewed
Jan 13, 2025
apps/meteor/client/views/account/preferences/AccountPreferencesPage.tsx
Outdated
Show resolved
Hide resolved
dougfabris
reviewed
Jan 13, 2025
rique223
force-pushed
the
feat/videoconf-volume-control
branch
from
55b63ff to
2909c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Integrated the VOIP
call ringer volumesetting from the user preferences page into Video conf, now both the dialing and ringing audio follow this setting, call ringer volume is relative to master volume so changing the master volume will also affect video conf/VOIP volumes.Demo video (play it from beginning):
https://www.loom.com/share/4ed189c1bc6649e1bc506bec2bb22fb2
New call ringer volume copy:
Issue(s)
Steps to test or reproduce
Further comments
Jira task: CONN-466