Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move VideoconfContext to ui-video-conf #34950

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 16, 2025

Proposed changes (including videos or screenshots)

This PR proposes to move VideoconfContext to the proper video conference package, giving more flexibility for using video conference context besides on meteor app

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 16, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 0c2062b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 7.3.0 milestone Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34950/

Built to branch gh-pages at 2025-01-21 04:59 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dougfabris dougfabris force-pushed the chore/videoconf-context branch from 4074932 to 86a29cd Compare January 16, 2025 15:55
@dougfabris dougfabris changed the title chore: Move videoconf context to ui-contexts chore: Move VideoconfContext to ui-video-conf Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (4e911b4) to head (0c2062b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34950      +/-   ##
===========================================
- Coverage    59.17%   59.17%   -0.01%     
===========================================
  Files         2822     2820       -2     
  Lines        68127    67699     -428     
  Branches     15149    15075      -74     
===========================================
- Hits         40316    40062     -254     
+ Misses       24979    24817     -162     
+ Partials      2832     2820      -12     
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review January 17, 2025 15:48
@dougfabris dougfabris requested review from a team as code owners January 17, 2025 15:48
@dougfabris dougfabris modified the milestones: 7.3.0, 7.4.0 Jan 20, 2025
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jan 21, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 21, 2025
@kodiakhq kodiakhq bot merged commit a5b4584 into develop Jan 21, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/videoconf-context branch January 21, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants