-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move VideoconfContext
to ui-video-conf
#34950
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
4074932
to
86a29cd
Compare
ui-contexts
VideoconfContext
to ui-video-conf
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34950 +/- ##
===========================================
- Coverage 59.17% 59.17% -0.01%
===========================================
Files 2822 2820 -2
Lines 68127 67699 -428
Branches 15149 15075 -74
===========================================
- Hits 40316 40062 -254
+ Misses 24979 24817 -162
+ Partials 2832 2820 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
This PR proposes to move
VideoconfContext
to the proper video conference package, giving more flexibility for using video conference context besides on meteor appIssue(s)
Steps to test or reproduce
Further comments