Skip to content

feat(roles): grant ML Data Manager collection and pipeline config perms#1215

Open
mihow wants to merge 1 commit intomainfrom
feat/ml-data-manager-collection-perms
Open

feat(roles): grant ML Data Manager collection and pipeline config perms#1215
mihow wants to merge 1 commit intomainfrom
feat/ml-data-manager-collection-perms

Conversation

@mihow
Copy link
Copy Markdown
Collaborator

@mihow mihow commented Apr 8, 2026

Summary

Follows up on #1212. Adds more permissions to the ML Data Manager role so they can fully manage the resources needed to run batch ML jobs:

  • Capture sets (collections): CREATE_COLLECTION, UPDATE_COLLECTION, DELETE_COLLECTION, POPULATE_COLLECTION
  • Pipeline configs: UPDATE_PROJECT_PIPELINE_CONFIG, DELETE_PROJECT_PIPELINE_CONFIG (already had CREATE)

These also flow to Project Manager via role inheritance.

Test plan

  • TestRolePermissions — all 4 role tests pass (ProjectManager already expected these as True)
  • TestMLDataManagerCanRunBatchMLJob — still passes
  • ami.users.tests — all 30 role/membership tests pass
  • Pre-commit hooks pass

Summary by CodeRabbit

  • Chores
    • Expanded MLDataManager role permissions to include collection management (create, update, delete, populate) and additional pipeline configuration operations (update, delete).

Add permissions to MLDataManager role:
- CREATE/UPDATE/DELETE_COLLECTION and POPULATE_COLLECTION (capture sets)
- UPDATE/DELETE_PROJECT_PIPELINE_CONFIG (already had CREATE)

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 8, 2026 02:21
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for antenna-preview ready!

Name Link
🔨 Latest commit 8ddf388
🔍 Latest deploy log https://app.netlify.com/projects/antenna-preview/deploys/69d5bb96d2465f0008bdc91d
😎 Deploy Preview https://deploy-preview-1215--antenna-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 8, 2026

Deploy Preview for antenna-ssec canceled.

Name Link
🔨 Latest commit 8ddf388
🔍 Latest deploy log https://app.netlify.com/projects/antenna-ssec/deploys/69d5bb96189d8b0008229574

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 573ff088-f163-436c-a3b4-9b5c9abc70de

📥 Commits

Reviewing files that changed from the base of the PR and between 83a970c and 8ddf388.

📒 Files selected for processing (1)
  • ami/users/roles.py

📝 Walkthrough

Walkthrough

Updated the MLDataManager role in ami/users/roles.py to extend its permissions set, adding six new permission codenames related to pipeline configuration management and collection operations: UPDATE/DELETE_PROJECT_PIPELINE_CONFIG and CREATE/UPDATE/DELETE/POPULATE_COLLECTION.

Changes

Cohort / File(s) Summary
MLDataManager Permissions Expansion
ami/users/roles.py
Extended MLDataManager.permissions set with six new permission codenames: UPDATE_PROJECT_PIPELINE_CONFIG, DELETE_PROJECT_PIPELINE_CONFIG, CREATE_COLLECTION, UPDATE_COLLECTION, DELETE_COLLECTION, and POPULATE_COLLECTION.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 Collections bloom and pipelines flow,
New permissions help our managers grow,
Six little powers, a hopping stride,
To update, delete, and populate with pride! 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: granting ML Data Manager role collection and pipeline config permissions.
Description check ✅ Passed The description covers the summary, list of changes, related issues, testing approach, and follows the template structure with all essential information provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ml-data-manager-collection-perms

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the MLDataManager role’s permission set so ML data managers (and, via inheritance, project managers) can manage capture set collections and project pipeline configs needed for running batch ML jobs, following up on #1212.

Changes:

  • Grant MLDataManager update/delete permissions for project pipeline configs.
  • Grant MLDataManager create/update/delete/populate permissions for collections.
  • Permissions continue to flow to ProjectManager through role inheritance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants