Make it possible for project managers to manually upload captures#790
Merged
Make it possible for project managers to manually upload captures#790
Conversation
✅ Deploy Preview for antenna-preview canceled.
|
annavik
commented
Apr 8, 2025
Member
Author
annavik
left a comment
annavik
left a comment
There was a problem hiding this comment.
Thanks a lot @mohamedelabbas1996 for the fix and also for adding tests! I did manual testing from UI for roles superadmin, basic member, identifier and project manager. Works well! 👌
Can't approve the PR since I opened it, but I approve! ✅
mihow
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #789 for background.
I tried to include
project_idas a param, but it's not enough. We also need some backend fix here! Can you help @mohamedelabbas1996?