Conversation
✅ Deploy Preview for antenna-preview canceled.
|
|
@mihow consider removing |
|
@annavik can we add the selector for Stations to this PR? Or at least allow a list of comma separated IDs for now? |
Yes, on it! :) |
Actually can we handle this as a follow up task? I realize we need new UI components for this and it would be helpful to have this merged 🙏 |
|
Can we merge this @mihow? |
mihow
left a comment
There was a problem hiding this comment.
I tested this with more existing collections and it seems to work well! The edit button is disabled for most existing collections because they use the "common_combined" sampling method which is now depreciated. So we should notify users that they will need to create new collections if they want to modify the parameters of existing collections. However, they can re-populate (e.g. update) the existing collections with the depreciated method.
Thanks for greatly improving our collections form!
Summary
In this PR we try to make the form for creating collections a bit more user friendly.
List of Changes
Related Issues
Closes #472.
Detailed Description
For the sampling method, we will still always pass "common_combined" to the backend. The new field "Type" is only there to make things easier to understand for users. I'm curious if we could try align this more with the sampling methods available on the backend side though.
As part of the changes, we are also trying to further align form components used in app, for example by introducing a shared
SaveButtoncomponent to streamline how loading state and success state is presented.Screenshots
Before:

After:



Deployment Notes
Users should be notified that their existing collections will no longer be editable.