-
Notifications
You must be signed in to change notification settings - Fork 177
Improve VC++ Redistributable installation logic #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactored the prerequisite check for Microsoft Visual C++ 2015-2022 Redistributable to use architecture-specific registry paths and version checks. The script now determines the OS architecture dynamically, checks for the required minimum version, and only downloads and installs the redistributable if necessary. Improved logging and error handling for better clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Visual C++ Redistributable prerequisite check to use a more robust architecture-specific approach. The refactored code dynamically detects OS architecture, performs version checking against registry values, and only installs the redistributable when necessary.
Key Changes:
- Replaced generic DisplayName-based registry search with architecture-specific registry path lookups using
RuntimeInformation::OSArchitecture - Updated minimum version requirement from 14.40.0.0 to 14.50.0.0
- Improved logging messages and error handling with more concise output
❌MegaLinter analysis: Error
Detailed Issues❌ REPOSITORY / gitleaks - 2 errorsLinter output file not found
|
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
closes #1089 |
Improve VC++ Redistributable installation logic

Refactored the prerequisite check for Microsoft Visual C++ 2015-2022 Redistributable to use architecture-specific registry paths and version checks. The script now determines the OS architecture dynamically, checks for the required minimum version, and only downloads and installs the redistributable if necessary. Improved logging and error handling for better clarity.