Skip to content

Conversation

Buzzwavemed
Copy link

@Buzzwavemed Buzzwavemed commented Sep 18, 2025

This pull request addresses issue #8049

Summary

  • introduce a Codex CLI-backed provider with persistent sessions, duplicate-response suppression, and reasoning-effort mapping
  • surface Codex throughout settings UI (model picker, CLI login helpers, dynamic model discovery) and shared messaging/types
  • update workspace tooling (tsconfig include paths) so scripts stay type-checked without interfering with Codex support

Testing

  • pnpm --filter roo-cline exec tsc --noEmit
  • pnpm --filter roo-cline exec vitest run api/providers/tests/codex.spec.ts

Important

Add support for Codex provider with CLI-backed sessions, UI integration, and model management.

  • Behavior:
    • Introduce Codex CLI-backed provider with persistent sessions and duplicate-response suppression in src/api/providers/codex.ts.
    • Add Codex support in src/api/index.ts and webview-ui/src/components/settings/ApiOptions.tsx.
    • Implement Codex CLI session management in src/integrations/codex/run.ts.
  • Models:
    • Add codexModels to packages/types/src/provider-settings.ts and webview-ui/src/components/settings/constants.ts.
    • Define Codex model types in packages/types/src/providers/codex.ts.
  • UI:
    • Add Codex provider option in webview-ui/src/components/settings/providers/Codex.tsx.
    • Update webview-ui/src/components/settings/ApiOptions.tsx to include Codex in provider selection.
  • Testing:
    • Add tests for Codex provider in src/api/providers/__tests__/codex.spec.ts.
  • Misc:
    • Update checkExistApiConfig.ts to recognize Codex as a provider that doesn't require additional keys.

This description was created by Ellipsis for 032b86b. You can customize this summary. It will automatically update as commits are pushed.

@Buzzwavemed Buzzwavemed changed the title Add Codex CLI provider support Added Codex provider support Sep 18, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Sep 18, 2025
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the Codex CLI provider implementation and found some issues that need attention, particularly with test file imports and error handling. The overall architecture looks solid, but there are opportunities to improve code clarity and maintainability.

Buzzwavemed and others added 8 commits September 18, 2025 15:17
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@Buzzwavemed Buzzwavemed marked this pull request as ready for review September 18, 2025 12:53
@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 12:53
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Sep 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces comprehensive Codex provider support through a CLI-backed implementation with persistent sessions, duplicate response filtering, and reasoning effort controls. The integration includes extensive UI components for provider configuration and authentication management.

  • Adds complete Codex provider with CLI session management and response deduplication
  • Integrates Codex throughout the settings UI with dynamic model discovery and authentication helpers
  • Updates type definitions and configuration schemas to support Codex provider settings

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
webview-ui/src/components/ui/hooks/useSelectedModel.ts Adds Codex model selection support
webview-ui/src/components/settings/providers/index.ts Exports new Codex provider component
webview-ui/src/components/settings/providers/OpenAICompatible.tsx Adds override props for model configuration
webview-ui/src/components/settings/providers/Codex.tsx Complete Codex provider UI with CLI management
webview-ui/src/components/settings/constants.ts Adds Codex to provider constants
webview-ui/src/components/settings/ApiOptions.tsx Integrates Codex provider in settings UI
src/shared/checkExistApiConfig.ts Includes Codex in providers not requiring API keys
src/shared/tests/checkExistApiConfig.spec.ts Adds test for Codex provider configuration
src/shared/WebviewMessage.ts Adds Codex-specific message types
src/shared/ExtensionMessage.ts Adds Codex model and status message types
src/integrations/codex/run.ts Core Codex CLI integration with session management
src/core/webview/webviewMessageHandler.ts Handles Codex CLI status and model discovery
src/api/providers/index.ts Exports CodexHandler
src/api/providers/codex.ts Main Codex provider implementation
src/api/providers/tests/codex.spec.ts Unit tests for Codex provider
src/api/index.ts Registers Codex provider in API factory
packages/types/src/providers/openai.ts Adds gpt-5-codex model definition
packages/types/src/providers/index.ts Exports Codex provider types
packages/types/src/providers/codex.ts Complete Codex type definitions and model presets
packages/types/src/provider-settings.ts Adds Codex provider schema and configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants