Skip to content

Conversation

annavester
Copy link

No description provided.

@jwo
Copy link
Member

jwo commented Jan 4, 2013

Two minor things here...

You define

self.wheels?
  4
end

The "?" at the end of a method usually means that you'll return a true/false value. So it's usually a wrapper for a boolean. a self.wheels would probably be better here.

For the inheritance heiarchy --- I was thinking you would:

class Vehicle
end

class Motorcycle < Vehicle
end

class Automobile < Vehicle
end

It's not a big deal either way; I was showing that all vehicles have some tires and share functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants