Skip to content

Conversation

adamxlowe
Copy link

Starting back on Ruby Off Rails track after a short hiatus. Completed Panda.

@color = hash[:color]
end
unless hash[:make].nil?
@make = hash[:make]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably "in-line" this... good rule of thumb, use in-line if there is only one statement in your "if/unless"

@make = hash[:make] if hash[:make]

Or, the example before:

@make = hash.fetch(:make, @make)
### which is similar to 
@make = hash.fetch(:make) {@make}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants