-
Notifications
You must be signed in to change notification settings - Fork 187
Feature/tool calling parser improvements #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhammalhotra28
wants to merge
7
commits into
main
Choose a base branch
from
feature/tool-calling-parser-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
409c108
feat: Add tool calling support with C++ as single source of truth
jmakwana06 e1b806e
fix: Address code review feedback
jmakwana06 cc577cf
fixes
shubhammalhotra28 1f1b42a
adding tab - to just see what's happenin when doing tool call - will …
shubhammalhotra28 65474bd
dordahs
shubhammalhotra28 c417ab4
fix(tool-calling): parser improvements and non-streaming fix
shubhammalhotra28 1105b10
poc
shubhammalhotra28 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RunanywhereAI/runanywhere-sdks
Length of output: 1695
🏁 Script executed:
Repository: RunanywhereAI/runanywhere-sdks
Length of output: 13260
Remove unused privacy API declarations: UserDefaults and SystemBootTime.
The codebase only uses
FileManager.attributesOfItem(atPath:)for file timestamp access, which correctly matches theNSPrivacyAccessedAPICategoryFileTimestampdeclaration. However, theNSPrivacyAccessedAPICategoryUserDefaultsandNSPrivacyAccessedAPICategorySystemBootTimeentries have no corresponding API usage in the code. Declaring unused APIs can trigger App Store review rejection. Remove these two unused entries and keep only the FileTimestamp declaration.🤖 Prompt for AI Agents