Improve multiple lti 1p3 connections and course copies #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes/improvements for loading the correct content on LTI1.3 launch.
Walked back one attempt to identify book when LMS does not send right context information. Causes issues if multiple books are intentionally linked or content was copied.
Reworked the rest to better handle combinations of multiple RS courses linked to one LMS course and copied content.
Backwards compatible with the exception of book page links (not assignment links) in LMS courses linked to multiple RS courses. Based on your DB dump, the only two possibly affected are:
Those courses may have to recreate the book links or hand edit them.
But should fix a bunch of possible headaches for others.