Skip to content

Add math-mode support for horizontal Parsons problems #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 87 additions & 6 deletions bases/rsptx/interactives/runestone/hparsons/js/hparsons.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ export default class HParsons extends RunestoneBase {
this.randomize = $(orig).data("randomize") ? true : false;
this.isBlockGrading = $(orig).data("blockanswer") ? true : false;
this.language = $(orig).data("language");
// Detect math mode
if (this.language === undefined && orig.textContent.includes('span class="process-math"')) {
this.language = "math";
}
if (this.isBlockGrading) {
this.blockAnswer = $(orig).data("blockanswer").split(" ");
}
Expand All @@ -47,6 +51,9 @@ export default class HParsons extends RunestoneBase {
this.controlDiv = null;
this.processContent(this.code);

this.microParsonToRaw = new Map();
this.simulatedSolution = [];

// Change to factory when more execution based feedback is included
if (this.isBlockGrading) {
this.feedbackController = new BlockFeedback(this);
Expand Down Expand Up @@ -83,10 +90,10 @@ export default class HParsons extends RunestoneBase {
this.unittest = this.processSingleContent(code, "--unittest--");
}

processSingleContent(code, delimitier) {
let index = code.indexOf(delimitier);
processSingleContent(code, delimiter) {
let index = code.indexOf(delimiter);
if (index > -1) {
let content = code.substring(index + delimitier.length);
let content = code.substring(index + delimiter.length);
let endIndex = content.indexOf("\n--");
content =
endIndex > -1 ? content.substring(0, endIndex + 1) : content;
Expand Down Expand Up @@ -119,6 +126,7 @@ export default class HParsons extends RunestoneBase {
};
InitMicroParsons(props);
this.hparsonsInput = $(this.outerDiv).find("micro-parsons")[0];
this.renderMathInBlocks();
}

createOutput() {
Expand Down Expand Up @@ -152,13 +160,64 @@ export default class HParsons extends RunestoneBase {
that.hparsonsInput.resetInput();
that.setLocalStorage();
that.feedbackController.reset();
that.renderMathInBlocks();
};
$(resetBtn).attr("type", "button");

$(this.outerDiv).prepend(ctrlDiv);
this.controlDiv = ctrlDiv;
}

// Decodes escaped HTML entities (like <) into raw characters
decodeHTMLEntities(str) {
const textarea = document.createElement("textarea");
textarea.innerHTML = str;
return textarea.value;
}

renderMathInBlocks() {
if (this.language !== "math") return;
setTimeout(() => {
const blocks = document.querySelectorAll(`#${this.divid}-container .parsons-block`);
blocks.forEach(block => {
block.innerHTML = this.decodeHTMLEntities(block.innerHTML);
});

if (window.MathJax && MathJax.typesetPromise) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition!

You should have a look at parsons.js and others for how we use the this.queueMathJax(specific item).

MathJax can create a big set of timing problems and this allows us to take control. Also trying to re-typeset the whole page can be a performance issue.

MathJax.typesetPromise().then(() => this.simulateSolution());
}
}, 0);
}

simulateSolution() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some comments about what the simulateSolution function is all about? Its not clear to me.. Is this for scoring? I would have guessed that block scoring would be fine? Maybe not for some expression.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnmnetp
The Micro-parsons code was formatting the math blocks with unpredictable Ascii characters, so I simulated the correct solution in the answer area and asked Micro-parsons to output what a correct solution would look like from their end. I needed this because a correct answer is determined by comparing the text on the blocks. I was hoping there would have been an ID on the blocks, but I didn't see any, so this was my workaround. I am sure there is a better way. Let me know if you have any ideas.

I can add more details to the PR tomorrow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying! I assume all of the \ ing of characters was the cause of the weird text.

I does not look like the html representation lends itself easily to adding ids.... But it seems like it should. maybe worth investigating with Rob, and looking at a better html (or json) representation to use in the javascript.

I'm ok with your solution for now, but thinking long term.

Copy link
Contributor Author

@geoff-cox geoff-cox Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding IDs could streamline future improvements and make grading in blockGrader.js more straightforward.

I designed this PR thinking that it would be a good way to construct formulas and equations term-by-term. Unfortunately, it doesn't currently support multiple correct orderings, which would be essential for commutative operations like addition and multiplication. So getting Rob (@rbeezer) involved in coordinating how multiple orderings can be communicated to Runestone would be good.

Copy link
Contributor Author

@geoff-cox geoff-cox Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, display math tags (<me>) are not currently supported with this PR, but <m>\displaystyle * </m> is good to go.

if (
this.simulatedSolution.length > 0 &&
this.microParsonToRaw instanceof Map &&
this.microParsonToRaw.size > 0
) { // Already initialized from local storage
this.feedbackController.solution = this.simulatedSolution;
this.feedbackController.grader.solution = this.simulatedSolution;
return;
}

this.microParsonToRaw = new Map();

const allBlocks = Array.from(
this.outerDiv.querySelectorAll("micro-parsons .parsons-block")
);
if (!this.blockAnswer || allBlocks.length === 0) return;

const rendered = this.hparsonsInput.getParsonsTextArray();
const raw = this.originalBlocks;
const correctOrder = this.blockAnswer.map(Number);

this.simulatedSolution = correctOrder.map(i => rendered[i]);
rendered.forEach((r, i) => this.microParsonToRaw.set(r, raw[i].trim()));

this.feedbackController.solution = this.simulatedSolution;
this.feedbackController.grader.solution = this.simulatedSolution;
}

// Return previous answers in local storage
//
localData() {
Expand Down Expand Up @@ -204,14 +263,36 @@ export default class HParsons extends RunestoneBase {
if (localData.count) {
this.feedbackController.checkCount = localData.count;
}
if (localData.simulatedSolution) {
this.simulatedSolution = localData.simulatedSolution;
}
if (localData.microParsonToRaw) {
this.microParsonToRaw = new Map(Object.entries(localData.microParsonToRaw));
} else {
this.microParsonToRaw = new Map();
}
}
// RunestoneBase: Set the state of the problem in local storage
setLocalStorage(data) {
let currentState = {};
if (data == undefined) {
currentState = {
answer: this.hparsonsInput.getParsonsTextArray(),
};
let userAnswer = this.hparsonsInput.getParsonsTextArray();

// In math mode, convert microParsons to raw before caching
// Additionally, save the solution and microParson ➜ Raw map.
if (this.language === "math") {
userAnswer = userAnswer.map(sym => this.microParsonToRaw.get(sym));
currentState = {
answer: userAnswer,
simulatedSolution: this.simulatedSolution,
microParsonToRaw: Object.fromEntries(this.microParsonToRaw),
};
} else {
currentState = {
answer: userAnswer,
};
}

if (this.isBlockGrading) {
// if this is block grading, add number of previous attempts too
currentState.count = this.feedbackController.checkCount;
Expand Down