Update CI #3835
Open
Update CI #3835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerboat9
force-pushed
the
use-24
branch
2 times, most recently
from
9c2ae78 to
cfa44f9
Compare
|
This should also update us from GCC 11 (!) to GCC 13 |
powerboat9
force-pushed
the
use-24
branch
2 times, most recently
from
5eb4493 to
641a4f5
Compare
CohenArthur
reviewed
Jul 4, 2025
| @@ -1 +1,5 @@ | |||
| ../../gcc/rust/checks/errors/borrowck/rust-borrow-checker-diagnostics.cc:145:46: warning: narrowing conversion of ‘loan’ from ‘Rust::Polonius::Loan’ {aka ‘long unsigned int’} to ‘uint32_t’ {aka ‘unsigned int’} [-Wnarrowing] | |||
| /usr/include/c++/13/bits/new_allocator.h:172:33: warning: ‘*(std::_Vector_base<Rust::FreeRegion, std::allocator<Rust::FreeRegion> >*)((char*)&saved + offsetof(Rust::BIR::PatternBindingBuilder::SavedState, Rust::BIR::PatternBindingBuilder::SavedState::regions.tl::optional<Rust::FreeRegions>::<unnamed>.tl::detail::optional_move_assign_base<Rust::FreeRegions, false>::<unnamed>.tl::detail::optional_copy_assign_base<Rust::FreeRegions, false>::<unnamed>.tl::detail::optional_move_base<Rust::FreeRegions, false>::<unnamed>.tl::detail::optional_copy_base<Rust::FreeRegions, false>::<unnamed>.tl::detail::optional_operations_base<Rust::FreeRegions>::<unnamed>.tl::detail::optional_storage_base<Rust::FreeRegions, false>::<unnamed>)).std::_Vector_base<Rust::FreeRegion, std::allocator<Rust::FreeRegion> >::_M_impl.std::_Vector_base<Rust::FreeRegion, std::allocator<Rust::FreeRegion> >::_Vector_impl::<anonymous>.std::_Vector_base<Rust::FreeRegion, std::allocator<Rust::FreeRegion> >::_Vector_impl_data::_M_start’ may be used uninitialized [-Wmaybe-uninitialized] | |||
There was a problem hiding this comment.
since these warnings originate from our code I think it might be good to spend some time and try to fix them while we update the CI to that new GCC version
There was a problem hiding this comment.
Since our bootstrap ci is passing, I'd think it would have to be a false positive.
There was a problem hiding this comment.
#3888 should take care of the narrowing one.
powerboat9
force-pushed
the
use-24
branch
3 times, most recently
from
0844d9c to
dc4b5b1
Compare
This updates us from ubuntu-22.04 to ubuntu-24.04, removes some dead code, and ensures we compile without network access in more places. Note that the binary we're using for GCC 5.4 appears to require ubuntu-22.04 and that this leaves updating the bootstrap CI for another time. ChangeLog: * .github/log_expected_warnings: Adjust expected warnings. * .github/workflows/ccpp32alpine.yml: Update from ubuntu-22.04 to ubuntu-24.04, remove ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION, and use case-insensitive grep to filter warnings. * .github/workflows/ccpp.yml: Likewise, compile without network access in more places, and remove commented-out warnings check in asan builder. Signed-off-by: Owen Avery <[email protected]>
|
@CohenArthur since the warnings are almost certainly false positives that would be hard to track down, can this PR be merged as-is? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figure it makes sense to update from
ubuntu-22.04toubuntu-24.04, andACTIONS_ALLOW_USE_UNSECURE_NODE_VERSIONshould be obsolete.