Fix: #![cfg_attr(..., feature)]` not respected #4334
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cfg_attr expansion and feature gate attribute handling Fixes Rust-GCC#4245 gcc/rust/ChangeLog: * checks/errors/feature/rust-feature-gate.cc (FeatureGate::visit): Added handling for META_ITEM type attributes to properly process feature gates. * expand/rust-cfg-strip.cc (expand_cfg_attrs): Fixed a bug where newly inserted cfg_attr attributes wheren't being reprocessed, and cleaned up the loop increment logic. Signed-off-by: lenny.chiadmi-delage <[email protected]>
Adds tests for the testsuite gcc/testsuite/ChangeLog: * rust/compile/issue-4245.rs: New test. Signed-off-by: lenny.chiadmi-delage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4245