fix: simplify ALSA buffer size and period configuration logic #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly reverts #990 for device compatibility, by letting ALSA calculate the period size from the device default period count. Forcing the period count to 2 caused underruns on some systems.
roderickvd
force-pushed
the
fix/alsa-buffer-size
branch
from
79fa7f4 to
46c3371
Compare
|
As the current code in |
roderickvd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use device default number of periods for better device compatibility.
Problem
#990 broke playback on one of my USB devices on a Raspberry Pi 4 with the following error immediately on opening the stream:
Changing to use
set_period_timeinstead ofset_period_sizefixes stream opening, but then runs into the same error minutes after playback.Investigations have shown that the root cause is to always set two periods. Reverting to the device defaults (four periods) fixes the issue.
Way Forward
I have reverted most of #990 (still: @attackgoat thanks a lot for your hard work on that!) to go back to the device defaults. Instead, with PR #1010 I am proposing an ergonomic API to set platform-specific options like the number of periods on ALSA.
I also submitted PR diwic/alsa-rs#137 to expose more Alsa getters and setters relevant to periods and buffers.