refactor(coreaudio): optimize buffer configuration #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreAudio automatically delivers callbacks with buffer_size = 2 * device_buffer_size. To ensure applications receive callbacks of the size they requested, configure device_buffer_size = requested_buffer_size / 2. This provides: - Predictable callback buffer sizes matching application requests - Efficient double-buffering (device buffer + callback buffer) - Low latency determined by the device buffer size
roderickvd
changed the title
roderickvd
changed the title
- Query actual device buffer size for accurate latency on macOS and iOS - Use device buffer size instead of callback buffer size when available - Add documentation and tests clarifying CoreAudio buffer model and behavior
Extract common stream format and buffer size configuration into configure_stream_format_and_buffer. Move callback variable setup to setup_callback_vars for code reuse and clarity.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Another part of the campaign on consistent buffer sizes. When done, I'm thinking of doing an alpha release and reaching out on Discord. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure CoreAudio device buffer to ensure applications receive callbacks with exactly the buffer size they requested. This provides the same predictable buffer behavior that PR #1013 proposes for ALSA.
Behavior
Latency is determined by the callback buffer size before transfer to the device hardware buffer. CoreAudio's buffer frame size corresponds to ALSA's "period" concept, with CoreAudio automatically implementing double buffering.