-
Notifications
You must be signed in to change notification settings - Fork 442
PipeWire implementation #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
midoriiro
wants to merge
18
commits into
RustAudio:master
Choose a base branch
from
midoriiro:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
bee0c4a
PipeWire implementation
midoriiro f4fce9c
Refactor client implementation/test + replace mpsc with crossbeam cha…
midoriiro b45bab8
Optimize imports
midoriiro 0a541b3
Add testcontainer and some tests depending of server configuration
midoriiro 70643fc
Optimize imports
midoriiro a5a4e87
Add tini as container entrypoint to handle process signal termination…
midoriiro 82dc7a3
Move items to test_utils module. Refactor tests to user containerized…
midoriiro e6838d3
Optimize imports
midoriiro 2b7258a
Replace listener trigger policy by control flow object. That give mor…
midoriiro 101fef5
Testing if listeners are properly released. Avoid server fixture crea…
midoriiro a9212f8
Remove serial_test dependency. All tests a containerized, no need to …
midoriiro ac9f825
Optimize imports
midoriiro e97ec08
Install libpipewire in jobs workflow
midoriiro faf68c6
Fix device stream callback
midoriiro a2f95fa
Better handling how to run tests (local and containers). Better handl…
midoriiro 5118f4a
Remove pipewire sub crates and use pipewire-client external crate
midoriiro 135eb4c
Add PipeWire information in README.md
midoriiro b32afbf
Merge branch 'master' into master
midoriiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/target | ||
/Cargo.lock | ||
target/ | ||
Cargo.lock | ||
.cargo/ | ||
.DS_Store | ||
recorded.wav | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -23,6 +23,16 @@ pub(crate) mod emscripten; | |||||
feature = "jack" | ||||||
))] | ||||||
pub(crate) mod jack; | ||||||
#[cfg(all( | ||||||
any( | ||||||
target_os = "linux", | ||||||
target_os = "dragonfly", | ||||||
target_os = "freebsd", | ||||||
target_os = "netbsd" | ||||||
), | ||||||
feature = "pipewire" | ||||||
))] | ||||||
pub(crate)mod pipewire; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing space between 'pub(crate)' and 'mod'. Should be 'pub(crate) mod pipewire;'.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
pub(crate) mod null; | ||||||
#[cfg(windows)] | ||||||
pub(crate) mod wasapi; | ||||||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jack feature was already defined implicitly. This line appears to be redefining it, which could cause confusion. Verify if this is intentional.
Copilot uses AI. Check for mistakes.