div with differently sized denominators
#799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
reviewed
Apr 7, 2025
| @@ -124,11 +127,17 @@ impl<const LIMBS: usize> Uint<LIMBS> { | |||
| // Copy out the remainder | |||
| y[0] = Limb::select(x[0], Limb(rem2), limb_div); | |||
| i = 1; | |||
| while i < LIMBS { | |||
|
|
|||
| let min = if LIMBS < RHS_LIMBS { LIMBS } else { RHS_LIMBS }; | |||
There was a problem hiding this comment.
From a constant-time perspective, is this ok? I think it is, but perhaps worth spelling out explicitly in a comment? Like "This does not invalidate the constant time contract, because the compiler will eliminate this branch"?
dvdplm
reviewed
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR in place, denominators are no longer required to be a
Uint/Intof the same number of limbs as the numerator, enabling more efficient division.