Skip to content

Add FromUniformBytes<64> to {k,p}256::Scalar #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

Add FromUniformBytes<64> to {k,p}256::Scalar #1379

merged 1 commit into from
Sep 3, 2025

Conversation

kayabaNerve
Copy link
Contributor

No description provided.

tarcieri
tarcieri approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to compose either the FromUniformBytes impl in terms of the Reduce<WideBytes> impl or vice versa, so we don't duplicate the implementation, but this is fine for now

@tarcieri tarcieri merged commit b595134 into RustCrypto:master Sep 3, 2025
37 checks passed
@tarcieri
Copy link
Member

tarcieri commented Sep 3, 2025

See also: #1341

@kayabaNerve kayabaNerve deleted the kp256-scalar-from-uniform-bytes branch September 3, 2025 16:58
@kayabaNerve kayabaNerve mentioned this pull request Sep 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayabaNerve @tarcieri