-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix feature alloc
and pem
in pkcs1
#1013
Conversation
This is technically a breaking change, although probably an OK one. You'll need to update the import gating accordingly, however, since the tests are now failing. |
(whoops sorry, didn't mean to close it) |
Avoid pulling in dep `pkcs8` or `zeroize` just because feature `alloc`/`pem`/`std` is enabled. Also removes unused dependency `zeeroize` and replace it with a feature. Signed-off-by: Jiahao XU <[email protected]>
@tarcieri Thanks, I've fixed the error and I believe this PR does not include any breaking change, since
|
Sorry that somehow I did not receive any notification for your reply. |
I've also run |
@tarcieri All checks have passed, this PR is ready for another review. |
@NobodyXu the breaking change would be features being implicitly enabled before and not any longer. That's not going to be caught by a tool like But it's minor enough it's probably a non-issue. |
Yeah you are right, I kind of ignore that because I thought it was wrong to enable @tarcieri Can you make a new release for |
Avoid pulling in dep
pkcs8
orzeroize
just because featurealloc
orpem
is enabled.