feat: [OpenAI] Integrate Messaging Convenience #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
reviewed
Feb 11, 2025
...on-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiContentItem.java
Show resolved
Hide resolved
rpanackal
force-pushed
the
feat/stable-conv-openai
branch
from
bb53787 to
2b4b12b
Compare
rpanackal
force-pushed
the
feat/openai-conv-api-msg
branch
from
60f9d72 to
c99cbb8
Compare
added 21 commits
February 17, 2025 15:14
- controller linked to new openai service only
- Move Jackson object initialization to field declaration - update `streamChatCompletionDeltas` in `NewOpenAiService` to use basic string message - `@deprecated` tag on deprecated `chatCompletion` doc - `@Deprecated` annotation on embedding api in client - `OpenAiController` streamChatCompletionDeltas emits usage
- make jackson mixin package private
…g unstable classes
- Use Old OpenAiService - Adapt tests
rpanackal
force-pushed
the
feat/stable-conv-openai
branch
from
b3ead80 to
f33bfad
Compare
added 7 commits
February 18, 2025 14:15
- Enums over string values in test - missed getContent assertion - replicate history test in old api test - Remove `@Value` from OpenAiChatCompletionDelta
…r visibility - follow createX naming format over toX. - move openai object mapper construction logic to utility method - make OpenAiChatCompletionDelta constructor access package private
- remove docs for overriding methods
added 8 commits
February 19, 2025 17:12
- Add user, assistant and system conv on par with orchestration - Adapt sample app service class for image input (new api) - Adapt toDTO to account for OpenAI gen model architecture
- Throw on unsupported content item - improve code quality user message to DTO mapper - Add unit tests for messaging convenience api
rpanackal
force-pushed
the
feat/openai-conv-api-msg
branch
from
538545c to
11c93c1
Compare
added 2 commits
February 20, 2025 10:31
…nai-conv-api-msg # Conflicts: # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiAssistantMessage.java # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiMessage.java # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiSystemMessage.java # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiUserMessage.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/NewOpenAiTest.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/services/NewOpenAiService.java
CharlesDuboisSAP
requested changes
Feb 20, 2025
| @@ -3,34 +3,23 @@ | |||
| import static com.sap.ai.sdk.foundationmodels.openai.OpenAiModel.GPT_35_TURBO; | |||
There was a problem hiding this comment.
This service class is in the test directory. Also I thought we wanted to remove NewXXX as a name
There was a problem hiding this comment.
The service class was intentionally moved to test dir, so we keep the e2e testing of the new api but not yet present it in the sample app.
I am open to any naming suggestions. eg:
OpenAiServiceV2, OpenAiV2Test
OpenAiServiceBeta, OpenAiBetaTest
OpenAiServiceGenerated, OpenAiGeneratedTest
There was a problem hiding this comment.
I have opted of OpenAiServiceV2 and OpenAiV2Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#172.
We have newly introduced a messaging API for orchestration. We would like to adapt the convenience to OpenAI module as well.
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDK