Add support for file-based-vcap-services app feature #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
As defined in [RFC-0030](https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0030-add-support-for-file-based-service-binding.md) if "file-based-vcap-services" app feature is enabled the VCAP_SERVICES content is store in a file, which location is given with the "VCAP_SERVICES_FILE_PATH" env var. This change is adding support for that use case.
beyhan
force-pushed
the
add-file-based-service-binding-support-for-vcap-services
branch
from
01a3bbd to
8c96f28
Compare
MatKuhr
previously approved these changes
Apr 3, 2025
Member
MatKuhr
left a comment
MatKuhr
left a comment
There was a problem hiding this comment.
Mostly LGTM, some minor questions on tests. I edited the PR description to contain a release note, so it should be ready 2 go 🥳
...ain/java/com/sap/cloud/environment/servicebinding/SapVcapServicesServiceBindingAccessor.java
Show resolved
Hide resolved
...java/com/sap/cloud/environment/servicebinding/SapVcapServicesServiceBindingAccessorTest.java
Show resolved
Hide resolved
…icebinding/SapVcapServicesServiceBindingAccessorTest.java Co-authored-by: Matthias Kuhr <[email protected]>
13 tasks
Contributor
|
@beyhan The btp-env-var library version 0.21.0 has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As defined in
RFC-0030 if
file-based-vcap-servicesapp feature is enabled theVCAP_SERVICEScontent is store in a file, which location is given with theVCAP_SERVICES_FILE_PATHenv var. This change is adding support for that use case.Release Notes
Add support for reading the
VCAP_SERVICEScontent from a JSON file underVCAP_SERVICES_FILE_PATHas defined inRFC-0030
Definition of Done