fix(core): Checkbox link in label is not clickable #12636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Comment on lines
11
to
13
| .fd-checkbox__label-container { | ||
| pointer-events: auto; | ||
| } |
There was a problem hiding this comment.
you can use:
&-container {
pointer-events: auto;
}
There was a problem hiding this comment.
Also, you need to bring this fix to fundamental-styles
|
Visit the preview URL for this PR (updated for commit bad99fb): https://fundamental-ngx-gh--pr12636-12577-core-fix-check-jw8dradi.web.app (expires Mon, 11 Nov 2024 22:24:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
InnaAtanasova
approved these changes
Oct 24, 2024
mikerodonnell89
approved these changes
Oct 24, 2024
|
@khotcholava e2e of checkbox are failing. Can you check them? |
dpavlenishvili
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): Checkbox link in label is not clickable
closes #12577
Description
Updated the checkbox component to ensure that links within custom labels are clickable and function as intended. This resolves the issue observed in the documentation example.
Before
Screencast.from.2024-10-23.16-34-31.webm
After
new.webm