Require namespace-qualified names in string values #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
requested review from
BerSie,
HeikoTheissen,
MarcelWaechter,
ThomasChadzelek,
drktfl and
uhlmannm
ThomasChadzelek
approved these changes
Sep 6, 2023
Contributor
HeikoTheissen
left a comment
HeikoTheissen
left a comment
There was a problem hiding this comment.
I'd prefer if the UI5 model implements alias resolution with the help of a "hardcoded" list of term (property) names. Such a list can be built automatically (during UI5 build) with the help of the Node.js function from #280.
uhlmannm
approved these changes
Sep 6, 2023
Member
@HeikoTheissen Yes, but your proposal is really something bigger, in particular if we include an automation using the UI5 build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.