Skip to content

Conversation

@HeikoTheissen
Copy link
Contributor

No description provided.

uhlmannm
uhlmannm previously approved these changes Oct 16, 2025
uhlmannm
uhlmannm previously approved these changes Oct 21, 2025
@HeikoTheissen HeikoTheissen marked this pull request as ready for review October 23, 2025 10:42
uhlmannm
uhlmannm previously approved these changes Nov 11, 2025
@HeikoTheissen
Copy link
Contributor Author

Note that the algorithm is ambiguous is borderline cases. Consider the linear hierarchy A - B - C - D. If TopLevels is called with Levels=3 and ExpandLevels=[C0,B2], then the result depends on the order in which the entries are processed:

  • C0 then B2 gives A - B - C - D
  • B2 then C0 gives A - B - C.

(If Levels=2, the processing order can only be B2 then C0, because C is not visible at first.)

@ThomasChadzelek
Copy link
Member

ThomasChadzelek commented Nov 12, 2025

Note that the algorithm is ambiguous is borderline cases.

I agree. But then again, I don't think we really need to provide an algorithm here. The intention is that C0 overrides B2 locally, that is, in the end C needs to be collapsed. This corresponds to a user who first expanded B by 2 and then collapsed C again. If it would have been the other way around, we at least (v4.ODataModel) would have removed C0 - and others could do as well!

P.S.: Would it help to add some order like "top down"?

</Property>
<Property Name="MessageCount" Type="Collection(Hierarchy.MessageCountType)" Nullable="false">
<Annotation Term="Common.Experimental" />
<Annotation Term="Core.Description" String="Number of messages for each severity a [matching](#MatchCount) descendant of a node has in the unlimited hierarchy" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we refer to "matching" here? Are we only interested in messages for the matching nodes? If their ancestors are added as well, would we not show their messages?

@HeikoTheissen
Copy link
Contributor Author

Do we need the same for Analytics.MultiLevelExpand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants