Fix: The adaptive card manifest should not be saved. #2902
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An empty adaptive card manifest was getting saved with this change the adaptive card manifest should not be saved.
🦋 Changeset detectedLatest commit: f3d09fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Sharmavksh
changed the title
Sharmavksh
requested review from
vivekguptasap and
Klaus-Keller
and removed request for
vivekguptasap
|
Klaus-Keller
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks @Sharmavksh.
- code to not write
adaptive-file looks good - changeset exists
- tests are adjusted
- did a visual review, no manual test
Approved from my side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent saving of an empty adaptive card manifest.