Skip to content

Conversation

@psmul
Copy link
Contributor

@psmul psmul commented Oct 16, 2025

No description provided.

@psmul psmul self-assigned this Oct 16, 2025
@psmul psmul requested a review from a team as a code owner October 16, 2025 09:49
@github-actions github-actions bot marked this pull request as draft October 16, 2025 09:50
*
* Affects: `WithCredentialsInterceptor`
*/
enableWithCredentialsByDefault?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick]
This change affects only calls to OCC.
let's reflect it in the toggle name, e.g.:
occWithCredentialsByDefault

PS. I was never a fan of using the word enable in the toggles names. They should describe the change in behavior and that's it. By setting it to true, we just enable it 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, fully agreed with this suggestion, thanks 👍🏼

@psmul psmul marked this pull request as ready for review October 17, 2025 09:27
@github-actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 20, 2025 08:07
@psmul psmul changed the title feat: (CXSPA-11133) enable useWithCredentials by default for occ config [PARKED] feat: (CXSPA-11133) enable useWithCredentials by default for occ config Oct 20, 2025
@github-actions
Copy link
Contributor

🚨 PR Title Validation Failed 🚨

Your pull request title does not follow the required format. Please update it to match the expected pattern:

Expected format:
<type>: <subject>

Allowed Types

  • docs: Changes to documentation only
  • feat: New feature work
  • fix: Bug fixes
  • perf: Code improvements for performance
  • refactor: Code changes that are not bug fixes or features
  • style: Code style changes (e.g., whitespace, formatting)
  • test: Adding or updating tests
  • chore: Build, CI, scripts, configs, etc.

Example of a valid PR title

feat: Add user authentication
fix: Resolve checkout bug
docs: Update API documentation

Merge is blocked until the PR title is corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants