-
Notifications
You must be signed in to change notification settings - Fork 400
[PARKED] feat: (CXSPA-11133) enable useWithCredentials by default for occ config #20804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
[PARKED] feat: (CXSPA-11133) enable useWithCredentials by default for occ config #20804
Conversation
projects/storefrontapp/src/app/spartacus/spartacus-b2c-configuration.module.ts
Outdated
Show resolved
Hide resolved
| * | ||
| * Affects: `WithCredentialsInterceptor` | ||
| */ | ||
| enableWithCredentialsByDefault?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick]
This change affects only calls to OCC.
let's reflect it in the toggle name, e.g.:
occWithCredentialsByDefault
PS. I was never a fan of using the word enable in the toggles names. They should describe the change in behavior and that's it. By setting it to true, we just enable it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, fully agreed with this suggestion, thanks 👍🏼
Co-authored-by: Krzysztof Platis <[email protected]>
projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
Outdated
Show resolved
Hide resolved
Merge Checks Failed |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
No description provided.