Bump 4.6.0

CHANGES.rst

@@ -1,6 +1,15 @@
 Changelog
 =========
 
+4.6.0
+-----
+
+Features
+~~~~~~~~
+
+- Fixed import issue with SQLAlchemy 2.1 preview
+- Fixed an issue causing ``with_for_update`` to fail if ``of`` was not a column list
+
 4.5.0
 -----
 

pyproject.toml

@@ -45,7 +45,7 @@ maintainers = [
 name = "sqlalchemy-hana"
 readme = "README.rst"
 requires-python = "~=3.10"
-version = "4.5.0"
+version = "4.6.0"
 
 [project.optional-dependencies]
 alembic = ["alembic~=1.12"]

sqlalchemy_hana/dialect.py

@@ -76,9 +76,15 @@
 if sqlalchemy.__version__ < "2.1":
     from sqlalchemy.sql.ddl import _DropView as BaseDropView
 else:
+    # In SQLAlchemy 2.1, the _DropView class was renamed to DropView.
+    # Also CreateView was added
     # isort moves the comments around leading to issues
     # isort: off
-    # In SQLAlchemy 2.1, the _DropView class was renamed to DropView.
+    # pylint:disable-next=no-name-in-module
+    from sqlalchemy.sql.ddl import (  # type: ignore[attr-defined]
+        CreateView as BaseCreateView,
+    )
+
     # pylint:disable-next=no-name-in-module
     from sqlalchemy.sql.ddl import (  # type: ignore[attr-defined,no-redef]
         DropView as BaseDropView,
@@ -459,6 +465,11 @@ def visit_unique_constraint(
         text += self.define_constraint_deferrability(constraint)
         return text
 
+    def visit_create_table_as(self, element: Any, **kw: Any) -> str:
+        result = super().visit_create_table_as(element, **kw)  # type: ignore[misc]
+        prefix, sep, select_sql = result.partition(" AS ")
+        return f"{prefix}{sep}({select_sql})"
+
     @override
     def visit_create_table(self, create: CreateTable, **kw: Any) -> str:
         table = create.element
@@ -502,9 +513,11 @@ def visit_computed_column(self, generated: Computed, **kw: Any) -> str:
         )
         return f"{clause} ({expression})"
 
-    def visit_create_view(self, create: CreateView, **kw: Any) -> str:
+    def visit_create_view(self, create: CreateView | BaseCreateView, **kw: Any) -> str:
+        name = getattr(create, "name", getattr(create, "table_name", None))
+        assert name, "Missing view name"
         selectable = self.sql_compiler.process(create.selectable, literal_binds=True)
-        return f"CREATE VIEW {create.name} AS {selectable}"
+        return f"CREATE VIEW {name} AS {selectable}"
 
     @override
     def visit_drop_view(self, drop: DropView | BaseDropView, **kw: Any) -> str:

test/test_sqlalchemy_dialect_suite.py

@@ -231,6 +231,9 @@ def test_index_typed_comparison(self):
     def test_path_typed_comparison(self):
         pytest.skip("Path typed access is not supported")
 
+    def test_index_cross_casts(self):
+        pytest.skip("JSON joins are not supported")
+
 
 class BizarroCharacterTest(_BizarroCharacterTest):